Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2512553006: [ObjC ARC] Converts ios/chrome/browser/interstitials:interstitials to ARC.Automatically generated… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/interstitials:interstitials to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/ed170221f82d5822cc180b0bcdb7d67901909e0e Cr-Commit-Position: refs/heads/master@{#436301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M ios/chrome/browser/interstitials/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/interstitials/ios_chrome_controller_client.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/interstitials/ios_chrome_metrics_helper.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/interstitials/ios_security_interstitial_page.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
stkhapugin
ptal. passes downstream tests.
4 years, 1 month ago (2016-11-18 17:00:46 UTC) #4
stkhapugin
ping
4 years, 1 month ago (2016-11-22 17:31:33 UTC) #7
sdefresne
lgtm
4 years, 1 month ago (2016-11-23 09:42:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512553006/1
4 years ago (2016-11-24 12:52:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/304103)
4 years ago (2016-11-24 15:22:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512553006/1
4 years ago (2016-12-05 14:51:01 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 15:58:11 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-05 16:00:41 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed170221f82d5822cc180b0bcdb7d67901909e0e
Cr-Commit-Position: refs/heads/master@{#436301}

Powered by Google App Engine
This is Rietveld 408576698