Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: build/config/ios/rules.gni

Issue 2512553005: Cleanup ios_xctest_test template. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index ec8c087fb5319f48a8487ac74bdd9e3e9825cdf1..d6413633829f6fa4be14ab248815c75d75f5c1b7 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -1270,14 +1270,6 @@ template("ios_xctest_test") {
_output_name = invoker.output_name
}
- # TODO(crbug.com/662404): Remove when all downstream uses has been removed.
- # If the variable is overridden, assert that it is true as all uses should
- # have set it to true (otherwise changing the default would break things).
- if (defined(invoker.use_new_naming_convention)) {
- assert(invoker.use_new_naming_convention,
- "use_new_naming_convention must be true if defined.")
- }
-
_xctest_target = _target_name + "_module"
_xctest_output = _output_name + "_module"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698