Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2512553005: Cleanup ios_xctest_test template. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years, 1 month ago
Reviewers:
jif
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup ios_xctest_test template. No caller of this template (neither upstream nor downstream) set the use_new_naming_convention parameter, so remove support for it from the template as last cleanup step. BUG=662404 Committed: https://crrev.com/09cceadb789bf9836f6f3bb6bd342df94e34b15c Cr-Commit-Position: refs/heads/master@{#433176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M build/config/ios/rules.gni View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sdefresne
Please take a look. Please do not send to CQ as one downstream CL need ...
4 years, 1 month ago (2016-11-18 08:36:14 UTC) #4
jif
lgtm
4 years, 1 month ago (2016-11-18 09:00:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512553005/1
4 years, 1 month ago (2016-11-18 09:38:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 11:21:00 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 11:23:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09cceadb789bf9836f6f3bb6bd342df94e34b15c
Cr-Commit-Position: refs/heads/master@{#433176}

Powered by Google App Engine
This is Rietveld 408576698