Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2512523002: Move web_view_interaction_test_util out of earl_grey_test_support (Closed)

Created:
4 years, 1 month ago by baxley
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move web_view_interaction_test_util out of earl_grey_test_support This test utilitiy doesn't rely upon EarlGrey, and users of it shouldn't be coupled to EarlGrey. BUG=666065 Committed: https://crrev.com/70494244cb21af856b002329726c79d2c5dde033 Cr-Commit-Position: refs/heads/master@{#432705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ios/web/BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
baxley
4 years, 1 month ago (2016-11-16 21:42:46 UTC) #3
Eugene But (OOO till 7-30)
lgtm
4 years, 1 month ago (2016-11-16 21:52:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512523002/1
4 years, 1 month ago (2016-11-16 21:56:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/69187)
4 years, 1 month ago (2016-11-17 00:55:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512523002/1
4 years, 1 month ago (2016-11-17 01:04:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 02:14:09 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 02:16:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70494244cb21af856b002329726c79d2c5dde033
Cr-Commit-Position: refs/heads/master@{#432705}

Powered by Google App Engine
This is Rietveld 408576698