Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2512483002: Support reloading from source on top of a script snapshot. (Closed)

Created:
4 years, 1 month ago by Cutch
Modified:
4 years, 1 month ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support reloading from source on top of a script snapshot. - [x] Add arguments `rootLibUri` and `packagesUri` to the reload service rpc. These allow the uri of the root library and the .packages files to be overridden. - [x] When pairing libraries during reload, support the base url changing. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f43b48e34d2f9a5d22c270913fab26cfdceb415b

Patch Set 1 #

Patch Set 2 : Support reloading from source on top of a script snapshot. #

Patch Set 3 : self review #

Patch Set 4 : bug fixes #

Total comments: 2

Patch Set 5 : rmacnak review #

Patch Set 6 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -23 lines) Patch
M runtime/include/dart_api.h View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/isolate_reload.h View 1 2 3 4 4 chunks +13 lines, -4 lines 0 comments Download
M runtime/vm/isolate_reload.cc View 1 2 3 4 8 chunks +111 lines, -9 lines 0 comments Download
M runtime/vm/object_reload.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 3 chunks +17 lines, -3 lines 0 comments Download
M runtime/vm/unit_test.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 1 month ago (2016-11-16 20:04:17 UTC) #3
rmacnak
LGTM https://codereview.chromium.org/2512483002/diff/60001/runtime/vm/unit_test.cc File runtime/vm/unit_test.cc (right): https://codereview.chromium.org/2512483002/diff/60001/runtime/vm/unit_test.cc#newcode293 runtime/vm/unit_test.cc:293: fprintf(stderr, "RELOAD REPORT:\n%s\n", js.ToCString()); OS::PrintErr
4 years, 1 month ago (2016-11-17 18:35:38 UTC) #4
Cutch
https://codereview.chromium.org/2512483002/diff/60001/runtime/vm/unit_test.cc File runtime/vm/unit_test.cc (right): https://codereview.chromium.org/2512483002/diff/60001/runtime/vm/unit_test.cc#newcode293 runtime/vm/unit_test.cc:293: fprintf(stderr, "RELOAD REPORT:\n%s\n", js.ToCString()); On 2016/11/17 18:35:38, rmacnak wrote: ...
4 years, 1 month ago (2016-11-17 19:28:21 UTC) #5
Cutch
4 years, 1 month ago (2016-11-17 19:29:19 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
f43b48e34d2f9a5d22c270913fab26cfdceb415b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698