Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: components/proximity_auth/screenlock_bridge.cc

Issue 2512473004: cros: Enable WebUILoginView reuse. (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/proximity_auth/screenlock_bridge.cc
diff --git a/components/proximity_auth/screenlock_bridge.cc b/components/proximity_auth/screenlock_bridge.cc
index d3996b17b05b600282c4d390c98dabf7ea3cd4ba..0663dda5403d95d930094b26cc68b3107d51014a 100644
--- a/components/proximity_auth/screenlock_bridge.cc
+++ b/components/proximity_auth/screenlock_bridge.cc
@@ -117,13 +117,13 @@ ScreenlockBridge* ScreenlockBridge::Get() {
}
void ScreenlockBridge::SetLockHandler(LockHandler* lock_handler) {
- DCHECK(lock_handler_ == nullptr || lock_handler == nullptr);
-
// Don't notify observers if there is no change -- i.e. if the screen was
// already unlocked, and is remaining unlocked.
if (lock_handler == lock_handler_)
return;
+ DCHECK(lock_handler_ == nullptr || lock_handler == nullptr);
+
// TODO(isherman): If |lock_handler| is null, then |lock_handler_| might have
// been freed. Cache the screen type rather than querying it below.
LockHandler::ScreenType screen_type;
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698