Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2512473003: Revert of Update the V8 version for Chromium branch 56. (Closed)

Created:
4 years, 1 month ago by vogelheim
Modified:
4 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update the V8 version for Chromium branch 56. (patchset #2 id:20001 of https://codereview.chromium.org/2513573003/ ) Reason for revert: There's several breakages with this CL in the blame list. Original issue's description: > Update the V8 version for Chromium branch 56. > > This is a roll-back to 5.6.309. This is the most stable candidate out of the latest Canaries. > > If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. > > When in doubt please try to contact the committer and reviewers of this CL before reverting it. > > TBR=machenbach@chromium.org > NOTRY=true > > Committed: https://crrev.com/194ed1a9cf5a86775bca4f976bc9e8b7c3f733d6 > Cr-Commit-Position: refs/heads/master@{#432876} TBR=machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/41ad5a846d44f2134f7975c38d305c13321a90d5 Cr-Commit-Position: refs/heads/master@{#432890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vogelheim
Created Revert of Update the V8 version for Chromium branch 56.
4 years, 1 month ago (2016-11-17 16:30:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512473003/1
4 years, 1 month ago (2016-11-17 16:31:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 16:32:41 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/41ad5a846d44f2134f7975c38d305c13321a90d5 Cr-Commit-Position: refs/heads/master@{#432890}
4 years, 1 month ago (2016-11-17 16:34:54 UTC) #6
Michael Achenbach
4 years, 1 month ago (2016-11-17 16:45:49 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698