third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js - Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing. (Closed)

Patch Set: rebased Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

index 60c597f2d43fac76984be289a624c7420531b011..f92e5af77bee0db9a41a6631d4d91106632f5c5b 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

@@ -229,7 +229,7 @@ Console.ConsoleViewMessage = class {

if (consoleMessage.level === SDK.ConsoleMessage.MessageLevel.Error ||

consoleMessage.level === SDK.ConsoleMessage.MessageLevel.RevokedError) {

messageElement.createTextChild(consoleMessage.request.requestMethod + ' ');

- messageElement.appendChild(Components.Linkifier.linkifyUsingRevealer(

+ messageElement.appendChild(Components.Linkifier.linkifyRevealable(

consoleMessage.request, consoleMessage.request.url, consoleMessage.request.url));

if (consoleMessage.request.failed) {

messageElement.createTextChildren(' ', consoleMessage.request.localizedFailDescription);

@@ -269,7 +269,7 @@ Console.ConsoleViewMessage = class {

* @this {SDK.ConsoleMessage}

function linkifyRequest(title) {

- return Components.Linkifier.linkifyUsingRevealer(

+ return Components.Linkifier.linkifyRevealable(

/** @type {!SDK.NetworkRequest} */ (this.request), title, this.request.url);

}