third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html - Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html

Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing. (Closed)

Patch Set: rebased Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html

diff --git a/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html b/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html

index f0dff031bb613d72223d7f8434a46e9fa7eac2db..403ad5db62f014c70ce22ac140ee63b08722cc48 100644

--- a/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html

+++ b/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html

@@ -57,8 +57,9 @@ function test()

var fragment = Components.linkifyStringAsFragment(linkifyMe);

var anchor = fragment.querySelector('a');

InspectorTest.addResult("The string \"" + linkifyMe + " \" linkifies to url: " + anchor.href);

- InspectorTest.addResult("The lineNumber is " + anchor.lineNumber + " with type " + (typeof anchor.lineNumber));

- InspectorTest.addResult("The columnNumber is " + anchor.columnNumber + " with type " + (typeof anchor.columnNumber));

+ var info = Components.Linkifier._linkInfo(anchor);

+ InspectorTest.addResult("The lineNumber is " + (info && info.lineNumber));

+ InspectorTest.addResult("The columnNumber is " + (info && info.columnNumber));

linkifier = new Components.Linkifier();

var count1 = liveLocationsCount();