third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js - Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js

Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing. (Closed)

Patch Set: unified click handler Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('K') | « third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js b/third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js

index c9c483b2cde85a0786d77886f9fb66780336dfac..82079d040746a11d63b0788d635daa21d0364190 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js

@@ -175,7 +175,7 @@ Sources.FileBasedSearchResultsPane.FileTreeElement = class extends TreeElement {

* @return {!Element}

_createAnchor(uiSourceCode, lineNumber, columnNumber) {

- return Components.Linkifier.linkifyUsingRevealer(uiSourceCode.uiLocation(lineNumber, columnNumber), '');

+ return Components.Linkifier.linkifyRevealable(uiSourceCode.uiLocation(lineNumber, columnNumber), '');

}

/**