third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html - Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html

Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing. (Closed)

Patch Set: unified click handler Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('j') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html

diff --git a/third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html b/third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html

index 8e363bc5d3bef13e4eabb7a5cf947565d76e73b8..2f329123b286574a3dd4a27835af7133ddf73f1a 100644

--- a/third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html

+++ b/third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html

@@ -223,7 +223,8 @@ function test()

var linkifier = new Components.Linkifier();

var anchorURI = uiSourceCode.url();

var anchor = linkifier.linkifyScriptLocation(SDK.targetManager.mainTarget(), null, anchorURI, 10, 1);

- Common.Revealer.revealPromise(anchor[Components.Linkifier._uiLocationSymbol]).then(function() {

+ var info = Components.Linkifier._linkInfo(anchor);

+ Common.Revealer.revealPromise(info.uiLocation).then(function() {

InspectorTest.addResult("Selection: " + panel.visibleView.textEditor.selection().toString());

dumpSelection("Showed anchor in " + anchorURI.split("/").pop() + " with line 333 column 3");

rollback();