third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js - Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js

Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing. (Closed)

Patch Set: unified click handler Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/console/console-links-on-messages-before-inspection-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js

index baba1f2760640f74562a85505056a301a2bdfa71..49fd944bd9ee92fbba5d2fcd7a2945e15898670d 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js

@@ -402,7 +402,8 @@ function extractLinkText(element)

if (!anchor)

return element.textContent;

var anchorText = anchor.textContent;

- var uiLocation = anchor[Components.Linkifier._uiLocationSymbol];

+ var info = Components.Linkifier._linkInfo(anchor);

+ var uiLocation = info && info.uiLocation;

var anchorTarget = uiLocation ? (uiLocation.uiSourceCode.name() + ":" + (uiLocation.lineNumber + 1) + ":" + (uiLocation.columnNumber + 1)) : "";

return anchorText + " -> " + anchorTarget;

}