Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js

Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing. (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Sources.FileBasedSearchResultsPane = class extends Sources.SearchResultsPane { 7 Sources.FileBasedSearchResultsPane = class extends Sources.SearchResultsPane {
8 /** 8 /**
9 * @param {!Workspace.ProjectSearchConfig} searchConfig 9 * @param {!Workspace.ProjectSearchConfig} searchConfig
10 */ 10 */
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 this._showMoreMatchesTreeElement.onselect = this._showMoreMatchesElementSele cted.bind(this, startMatchIndex); 168 this._showMoreMatchesTreeElement.onselect = this._showMoreMatchesElementSele cted.bind(this, startMatchIndex);
169 } 169 }
170 170
171 /** 171 /**
172 * @param {!Workspace.UISourceCode} uiSourceCode 172 * @param {!Workspace.UISourceCode} uiSourceCode
173 * @param {number} lineNumber 173 * @param {number} lineNumber
174 * @param {number} columnNumber 174 * @param {number} columnNumber
175 * @return {!Element} 175 * @return {!Element}
176 */ 176 */
177 _createAnchor(uiSourceCode, lineNumber, columnNumber) { 177 _createAnchor(uiSourceCode, lineNumber, columnNumber) {
178 return Components.Linkifier.linkifyUsingRevealer(uiSourceCode.uiLocation(lin eNumber, columnNumber), ''); 178 return Components.Linkifier.linkifyRevealable(uiSourceCode.uiLocation(lineNu mber, columnNumber), '');
179 } 179 }
180 180
181 /** 181 /**
182 * @param {string} lineContent 182 * @param {string} lineContent
183 * @param {!Array.<!Common.SourceRange>} matchRanges 183 * @param {!Array.<!Common.SourceRange>} matchRanges
184 */ 184 */
185 _createContentSpan(lineContent, matchRanges) { 185 _createContentSpan(lineContent, matchRanges) {
186 var contentSpan = createElement('span'); 186 var contentSpan = createElement('span');
187 contentSpan.className = 'search-match-content'; 187 contentSpan.className = 'search-match-content';
188 contentSpan.textContent = lineContent; 188 contentSpan.textContent = lineContent;
(...skipping 19 matching lines...) Expand all
208 /** 208 /**
209 * @param {number} startMatchIndex 209 * @param {number} startMatchIndex
210 * @return {boolean} 210 * @return {boolean}
211 */ 211 */
212 _showMoreMatchesElementSelected(startMatchIndex) { 212 _showMoreMatchesElementSelected(startMatchIndex) {
213 this.removeChild(this._showMoreMatchesTreeElement); 213 this.removeChild(this._showMoreMatchesTreeElement);
214 this._appendSearchMatches(startMatchIndex, this._searchResult.searchMatches. length); 214 this._appendSearchMatches(startMatchIndex, this._searchResult.searchMatches. length);
215 return false; 215 return false;
216 } 216 }
217 }; 217 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698