Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2512353002: [DevTools] Refactor Linkifier to unify link processing. (Closed)
Patch Set: rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 messageElement = this._tryFormatAsError(/** @type {string} */ (conso leMessage.parameters[0].value)); 222 messageElement = this._tryFormatAsError(/** @type {string} */ (conso leMessage.parameters[0].value));
223 var args = consoleMessage.parameters || [messageText]; 223 var args = consoleMessage.parameters || [messageText];
224 messageElement = messageElement || this._format(args); 224 messageElement = messageElement || this._format(args);
225 } 225 }
226 } else if (consoleMessage.source === SDK.ConsoleMessage.MessageSource.Networ k) { 226 } else if (consoleMessage.source === SDK.ConsoleMessage.MessageSource.Networ k) {
227 if (consoleMessage.request) { 227 if (consoleMessage.request) {
228 messageElement = createElement('span'); 228 messageElement = createElement('span');
229 if (consoleMessage.level === SDK.ConsoleMessage.MessageLevel.Error || 229 if (consoleMessage.level === SDK.ConsoleMessage.MessageLevel.Error ||
230 consoleMessage.level === SDK.ConsoleMessage.MessageLevel.RevokedErro r) { 230 consoleMessage.level === SDK.ConsoleMessage.MessageLevel.RevokedErro r) {
231 messageElement.createTextChild(consoleMessage.request.requestMethod + ' '); 231 messageElement.createTextChild(consoleMessage.request.requestMethod + ' ');
232 messageElement.appendChild(Components.Linkifier.linkifyUsingRevealer( 232 messageElement.appendChild(Components.Linkifier.linkifyRevealable(
233 consoleMessage.request, consoleMessage.request.url, consoleMessage .request.url)); 233 consoleMessage.request, consoleMessage.request.url, consoleMessage .request.url));
234 if (consoleMessage.request.failed) { 234 if (consoleMessage.request.failed) {
235 messageElement.createTextChildren(' ', consoleMessage.request.locali zedFailDescription); 235 messageElement.createTextChildren(' ', consoleMessage.request.locali zedFailDescription);
236 } else { 236 } else {
237 messageElement.createTextChildren( 237 messageElement.createTextChildren(
238 ' ', String(consoleMessage.request.statusCode), ' (', consoleMes sage.request.statusText, ')'); 238 ' ', String(consoleMessage.request.statusCode), ' (', consoleMes sage.request.statusText, ')');
239 } 239 }
240 } else { 240 } else {
241 var fragment = 241 var fragment =
242 Components.linkifyStringAsFragmentWithCustomLinkifier(messageText, linkifyRequest.bind(consoleMessage)); 242 Components.linkifyStringAsFragmentWithCustomLinkifier(messageText, linkifyRequest.bind(consoleMessage));
(...skipping 19 matching lines...) Expand all
262 formattedMessage.appendChild(anchorElement); 262 formattedMessage.appendChild(anchorElement);
263 formattedMessage.appendChild(messageElement); 263 formattedMessage.appendChild(messageElement);
264 return formattedMessage; 264 return formattedMessage;
265 265
266 /** 266 /**
267 * @param {string} title 267 * @param {string} title
268 * @return {!Element} 268 * @return {!Element}
269 * @this {SDK.ConsoleMessage} 269 * @this {SDK.ConsoleMessage}
270 */ 270 */
271 function linkifyRequest(title) { 271 function linkifyRequest(title) {
272 return Components.Linkifier.linkifyUsingRevealer( 272 return Components.Linkifier.linkifyRevealable(
273 /** @type {!SDK.NetworkRequest} */ (this.request), title, this.request .url); 273 /** @type {!SDK.NetworkRequest} */ (this.request), title, this.request .url);
274 } 274 }
275 } 275 }
276 276
277 /** 277 /**
278 * @param {!SDK.ConsoleMessage} consoleMessage 278 * @param {!SDK.ConsoleMessage} consoleMessage
279 * @return {?Element} 279 * @return {?Element}
280 */ 280 */
281 _buildMessageAnchor(consoleMessage) { 281 _buildMessageAnchor(consoleMessage) {
282 var anchorElement = null; 282 var anchorElement = null;
(...skipping 950 matching lines...) Expand 10 before | Expand all | Expand 10 after
1233 * @return {!Element} 1233 * @return {!Element}
1234 */ 1234 */
1235 toMessageElement() { 1235 toMessageElement() {
1236 if (!this._element) { 1236 if (!this._element) {
1237 super.toMessageElement(); 1237 super.toMessageElement();
1238 this._element.classList.toggle('collapsed', this._collapsed); 1238 this._element.classList.toggle('collapsed', this._collapsed);
1239 } 1239 }
1240 return this._element; 1240 return this._element;
1241 } 1241 }
1242 }; 1242 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698