chrome/browser/resources/settings/people_page/sync_page.js - Issue 2512323002: MD Settings: In /syncSetup clicking links in checkbox label should not check/uncheck.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/sync_page.js

Issue 2512323002: MD Settings: In /syncSetup clicking links in checkbox label should not check/uncheck. (Closed)

Patch Set: add @private annotation to sync page function Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/people_page/sync_page.js

diff --git a/chrome/browser/resources/settings/people_page/sync_page.js b/chrome/browser/resources/settings/people_page/sync_page.js

index 7ac0f0db0e0672dfd21c4b62c5b09e8765d56071..c80178ccafd8381d5f532a799c661b343a48e49d 100644

--- a/chrome/browser/resources/settings/people_page/sync_page.js

+++ b/chrome/browser/resources/settings/people_page/sync_page.js

@@ -420,6 +420,16 @@ Polymer({

return !emptyPassphrase && !mismatchedPassphrase;

+ /**

+ * @param {!Event} event

+ * @private

+ */

+ onLearnMoreTap_: function(event) {

+ // Stop the propagation of events, so that clicking on links inside

+ // checkbox labels won't change the checkbox value.

+ event.stopPropagation();

+ }

});

})();