Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4905)

Unified Diff: chrome/test/data/webui/settings/people_page_sync_page_test.js

Issue 2512323002: MD Settings: In /syncSetup clicking links in checkbox label should not check/uncheck. (Closed)
Patch Set: remove outdated comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/people_page_sync_page_test.js
diff --git a/chrome/test/data/webui/settings/people_page_sync_page_test.js b/chrome/test/data/webui/settings/people_page_sync_page_test.js
index e39cc91fc850988250e4a6feb183aad3f46a83be..51c7bac5b6fa77073265041c7b0408fdb2fb1263 100644
--- a/chrome/test/data/webui/settings/people_page_sync_page_test.js
+++ b/chrome/test/data/webui/settings/people_page_sync_page_test.js
@@ -240,6 +240,23 @@ cr.define('settings_people_page_sync_page', function() {
return browserProxy.whenCalled('setSyncDatatypes').then(verifyPrefs);
});
+ test('ClickingLinkDoesNotChangeCheckboxValue', function() {
+ var syncAllDataTypesCheckbox = syncPage.$.syncAllDataTypesCheckbox;
+
+ // Uncheck the Sync All checkbox.
+ MockInteractions.tap(syncAllDataTypesCheckbox);
+
+ // Make sure the checkbox is enabled and checked
+ var link = syncPage.$.paymentLearnMore;
dpapad 2016/11/19 02:04:38 Probably worth ensuring that the parentElement/par
scottchen 2016/11/21 18:33:46 Done.
+ assertFalse(link.parentNode.disabled);
+ assertTrue(link.parentNode.checked);
+
+ MockInteractions.tap(link);
+
+ // The checkbox value should be unchanged after clicking on the link
dpapad 2016/11/19 02:04:38 Comments should have proper punctuation per style
scottchen 2016/11/21 18:33:46 Done.
+ assertTrue(link.parentNode.checked);
+ });
+
test('RadioBoxesEnabledWhenUnencrypted', function() {
// Verify that the encryption radio boxes are enabled.
assertFalse(encryptWithGoogle.disabled);

Powered by Google App Engine
This is Rietveld 408576698