Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: chrome/browser/resources/settings/people_page/sync_page.js

Issue 2512323002: MD Settings: In /syncSetup clicking links in checkbox label should not check/uncheck. (Closed)
Patch Set: remove outdated comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function() { 5 (function() {
6 6
7 /** 7 /**
8 * Names of the radio buttons which allow the user to choose their encryption 8 * Names of the radio buttons which allow the user to choose their encryption
9 * mechanism. 9 * mechanism.
10 * @enum {string} 10 * @enum {string}
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 validateCreatedPassphrases_: function() { 413 validateCreatedPassphrases_: function() {
414 var emptyPassphrase = !this.passphrase_; 414 var emptyPassphrase = !this.passphrase_;
415 var mismatchedPassphrase = this.passphrase_ != this.confirmation_; 415 var mismatchedPassphrase = this.passphrase_ != this.confirmation_;
416 416
417 this.$$('#passphraseInput').invalid = emptyPassphrase; 417 this.$$('#passphraseInput').invalid = emptyPassphrase;
418 this.$$('#passphraseConfirmationInput').invalid = 418 this.$$('#passphraseConfirmationInput').invalid =
419 !emptyPassphrase && mismatchedPassphrase; 419 !emptyPassphrase && mismatchedPassphrase;
420 420
421 return !emptyPassphrase && !mismatchedPassphrase; 421 return !emptyPassphrase && !mismatchedPassphrase;
422 }, 422 },
423
424 /**
425 * Stop the propagation of events, so that clicking on links inside checkbox
426 * labels won't change the checkbox value.
427 * @param {!Event} event
428 */
429 stopPropagation_: function(event) {
dpapad 2016/11/19 02:04:38 Nit: onLearnMoreTap_: function() { // Move comme
scottchen 2016/11/21 18:33:46 Done.
430 event.stopPropagation();
431 }
423 }); 432 });
424 433
425 })(); 434 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698