Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2512303002: Don't call stringify if we can prove that the type is a string. (Closed)

Created:
4 years, 1 month ago by Emily Fortuna
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't call stringify if we can prove that the type is a string. BUG=https://github.com/dart-lang/sdk/issues/27394 R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/3db16e52eb620f2c0c296ef0b97fed820940182f

Patch Set 1 : . #

Patch Set 2 : just updated comment instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M pkg/compiler/lib/src/ssa/kernel_string_builder.dart View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Emily Fortuna
4 years, 1 month ago (2016-11-19 00:22:50 UTC) #4
Harry Terkelsen
lgtm
4 years, 1 month ago (2016-11-19 00:35:30 UTC) #5
Harry Terkelsen
Add a test please
4 years, 1 month ago (2016-11-19 00:37:14 UTC) #6
Emily Fortuna
On 2016/11/19 00:37:14, Harry Terkelsen wrote: > Add a test please whelp, this CL turned ...
4 years, 1 month ago (2016-11-19 01:06:38 UTC) #7
Emily Fortuna
4 years, 1 month ago (2016-11-19 01:07:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
3db16e52eb620f2c0c296ef0b97fed820940182f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698