Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 2512263002: Pass raw response with Context-Encoding sdch if support is not configured. (Closed)

Created:
4 years, 1 month ago by mef
Modified:
4 years ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, Randy Smith (Not in Mondays)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass raw response with Context-Encoding sdch if support is not configured. BUG=666936 Committed: https://crrev.com/8c7da89358dd21e60be2725220696f29ef94c234 Cr-Commit-Position: refs/heads/master@{#435295}

Patch Set 1 #

Patch Set 2 : Added tests for explicit Accept-Encoding header value. #

Patch Set 3 : Fix net unittests. #

Total comments: 13

Patch Set 4 : Address Helen's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -3 lines) Patch
M components/cronet/ios/test/cronet_http_test.mm View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/url_request/url_request_http_job_unittest.cc View 1 2 3 3 chunks +42 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
xunjieli
I am fine with this approach, given that this is the behavior before the filter ...
4 years ago (2016-11-28 23:53:04 UTC) #3
mef
Thanks, Helen! I've fixed the test without SdchManager, and I've added another one with SdchManager, ...
4 years ago (2016-11-29 22:51:51 UTC) #4
xunjieli
Looks good. thanks for handling this. I will sign off after another pass. https://codereview.chromium.org/2512263002/diff/40001/components/cronet/ios/test/cronet_http_test.mm File ...
4 years ago (2016-11-29 23:30:42 UTC) #5
mef
Thanks, PTAL. https://codereview.chromium.org/2512263002/diff/40001/components/cronet/ios/test/cronet_http_test.mm File components/cronet/ios/test/cronet_http_test.mm (right): https://codereview.chromium.org/2512263002/diff/40001/components/cronet/ios/test/cronet_http_test.mm#newcode199 components/cronet/ios/test/cronet_http_test.mm:199: TEST_F(HttpTest, AcceptEncodingSdch) { On 2016/11/29 23:30:42, xunjieli ...
4 years ago (2016-11-30 15:51:07 UTC) #8
xunjieli
lgtm
4 years ago (2016-11-30 16:06:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512263002/60001
4 years ago (2016-11-30 16:53:25 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-30 16:58:53 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-30 17:01:59 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8c7da89358dd21e60be2725220696f29ef94c234
Cr-Commit-Position: refs/heads/master@{#435295}

Powered by Google App Engine
This is Rietveld 408576698