Clean up CFGAS_FontMgr

Clean up CFGAS_FontMgr

Committed: https://pdfium.googlesource.com/pdfium/+/78cb28a38481a46ceab861f4159e618509868f94

[npm, 2016-11-18 19:35:10]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 19:35:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-11-18 19:35:25]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[Tom Sepez, 2016-11-18 19:46:23]

lgtm

https://codereview.chromium.org/2512213002/diff/1/xfa/fgas/font/cfgas_fontmgr...
File xfa/fgas/font/cfgas_fontmgr.cpp (right):

https://codereview.chromium.org/2512213002/diff/1/xfa/fgas/font/cfgas_fontmgr...
xfa/fgas/font/cfgas_fontmgr.cpp:1175: uint16_t a[4];
nit: I'd unroll the loop at 1180 to maybe avoid having an array here. Your call.

https://codereview.chromium.org/2512213002/diff/1/xfa/fgas/font/cfgas_fontmgr...
xfa/fgas/font/cfgas_fontmgr.cpp:1191: if (pOS2) {
nit: can we make this !pOS2 and flip the blocks around (e.g. early return on
error rather than early return on success idiom).

[Tom Sepez, 2016-11-18 19:55:43]

https://codereview.chromium.org/2512213002/diff/1/xfa/fgas/font/cfgas_fontmgr...
File xfa/fgas/font/cfgas_fontmgr.cpp (right):

https://codereview.chromium.org/2512213002/diff/1/xfa/fgas/font/cfgas_fontmgr...
xfa/fgas/font/cfgas_fontmgr.cpp:1175: uint16_t a[4];
nit: maybe brace-initialization of this array.

[commit-bot: I haz the power, 2016-11-18 20:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 20:05:11]

Dry run: This issue passed the CQ dry run.

[npm, 2016-11-18 20:49:44]

https://codereview.chromium.org/2512213002/diff/1/xfa/fgas/font/cfgas_fontmgr...
File xfa/fgas/font/cfgas_fontmgr.cpp (right):

https://codereview.chromium.org/2512213002/diff/1/xfa/fgas/font/cfgas_fontmgr...
xfa/fgas/font/cfgas_fontmgr.cpp:1175: uint16_t a[4];
On 2016/11/18 19:46:23, Tom Sepez wrote:
> nit: I'd unroll the loop at 1180 to maybe avoid having an array here. Your
call.

I like loops

https://codereview.chromium.org/2512213002/diff/1/xfa/fgas/font/cfgas_fontmgr...
xfa/fgas/font/cfgas_fontmgr.cpp:1175: uint16_t a[4];
On 2016/11/18 19:55:43, Tom Sepez wrote:
> nit: maybe brace-initialization of this array.

Done.

https://codereview.chromium.org/2512213002/diff/1/xfa/fgas/font/cfgas_fontmgr...
xfa/fgas/font/cfgas_fontmgr.cpp:1191: if (pOS2) {
On 2016/11/18 19:46:23, Tom Sepez wrote:
> nit: can we make this !pOS2 and flip the blocks around (e.g. early return on
> error rather than early return on success idiom).

Done.

[npm, 2016-11-18 20:49:51]

The CQ bit was checked by npm@chromium.org

[npm, 2016-11-18 20:49:52]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2512213002/#ps20001
(title: "Nits")

[commit-bot: I haz the power, 2016-11-18 20:50:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 21:04:02]

Description was changed from

==========
Clean up CFGAS_FontMgr
==========

to

==========
Clean up CFGAS_FontMgr

Committed:
https://pdfium.googlesource.com/pdfium/+/78cb28a38481a46ceab861f4159e61850986...
==========

[commit-bot: I haz the power, 2016-11-18 21:04:03]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/78cb28a38481a46ceab861f4159e61850986...