Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2512203002: Clean up style in layout_tests/models/test_expectations.py. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up style in layout_tests/models/test_expectations.py. This includes cleaning up code layout, spelling in strings, and variable names, and running format-webkitpy in this file and its related unit test. This shouldn't affect behavior; all tests still pass. BUG=643937 Committed: https://crrev.com/5188bb7143c43f16b2393ba174ef9d1af2e442bc Cr-Commit-Position: refs/heads/master@{#433436}

Patch Set 1 #

Patch Set 2 : Reformat literal dicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -105 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 15 chunks +60 lines, -56 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py View 18 chunks +55 lines, -49 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
qyearsley
4 years, 1 month ago (2016-11-18 19:23:29 UTC) #3
jeffcarp
lgtm
4 years, 1 month ago (2016-11-18 19:28:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512203002/20001
4 years, 1 month ago (2016-11-18 20:22:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/335289)
4 years, 1 month ago (2016-11-18 23:41:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512203002/20001
4 years, 1 month ago (2016-11-19 19:03:17 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-20 00:03:06 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-20 00:06:09 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5188bb7143c43f16b2393ba174ef9d1af2e442bc
Cr-Commit-Position: refs/heads/master@{#433436}

Powered by Google App Engine
This is Rietveld 408576698