Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2512193002: [ObjC ARC] Converts ios/chrome/browser:browser_impl to ARC.Automatically generated ARCMigrate com… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser:browser_impl to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/b14005ec88afb781002383f3ae413e91d4a3fd54 Cr-Commit-Position: refs/heads/master@{#433570}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed compile guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 12:25:01 UTC) #6
sdefresne
https://codereview.chromium.org/2512193002/diff/1/ios/chrome/browser/ios_chrome_main_parts.mm File ios/chrome/browser/ios_chrome_main_parts.mm (right): https://codereview.chromium.org/2512193002/diff/1/ios/chrome/browser/ios_chrome_main_parts.mm#newcode61 ios/chrome/browser/ios_chrome_main_parts.mm:61: #if !defined(__has_feature) || !__has_feature(objc_arc) This should be out of ...
4 years, 1 month ago (2016-11-21 12:35:18 UTC) #7
stkhapugin
Thank you! https://codereview.chromium.org/2512193002/diff/1/ios/chrome/browser/ios_chrome_main_parts.mm File ios/chrome/browser/ios_chrome_main_parts.mm (right): https://codereview.chromium.org/2512193002/diff/1/ios/chrome/browser/ios_chrome_main_parts.mm#newcode61 ios/chrome/browser/ios_chrome_main_parts.mm:61: #if !defined(__has_feature) || !__has_feature(objc_arc) On 2016/11/21 12:35:18, ...
4 years, 1 month ago (2016-11-21 15:33:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512193002/20001
4 years, 1 month ago (2016-11-21 15:33:30 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-21 15:33:31 UTC) #12
sdefresne
lgtm
4 years, 1 month ago (2016-11-21 15:34:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512193002/20001
4 years, 1 month ago (2016-11-21 15:43:36 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 16:58:20 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 17:03:21 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b14005ec88afb781002383f3ae413e91d4a3fd54
Cr-Commit-Position: refs/heads/master@{#433570}

Powered by Google App Engine
This is Rietveld 408576698