Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2512183002: [ic] Ensure prototype validity cell guards global object's prototype changes for LoadGlobalIC. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Ensure prototype validity cell guards global object's prototype changes for LoadGlobalIC. BUG=chromium:666742, v8:5561 Committed: https://crrev.com/8ca50a88627a9427bb0dd102885a7c5b748eb8d6 Cr-Commit-Position: refs/heads/master@{#41136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M src/objects.cc View 1 chunk +11 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-666742.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-18 22:08:13 UTC) #6
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-21 11:31:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512183002/1
4 years, 1 month ago (2016-11-21 12:21:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 12:46:26 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 12:46:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ca50a88627a9427bb0dd102885a7c5b748eb8d6
Cr-Commit-Position: refs/heads/master@{#41136}

Powered by Google App Engine
This is Rietveld 408576698