Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2512163004: Fix version manager that flip flag in-flight does not make supported versions change. (Closed)

Created:
4 years, 1 month ago by mpw
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix version manager that flip flag in-flight does not make supported versions change. Protected by ENABLED FLAGS_quic_fix_version_manager. Merge internal change: 139033797 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -5 lines) Patch
M net/quic/core/quic_flags_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_protocol.h View 1 chunk +13 lines, -2 lines 0 comments Download
M net/quic/core/quic_protocol.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +68 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2512273002 Patch 1

Dependent Patchsets:

Issue 2506173006 Patch 1

Messages

Total messages: 4 (1 generated)
mpw
4 years, 1 month ago (2016-11-18 23:39:06 UTC) #1
Ryan Hamilton
nit: please tweak the CL description (and the Final) to reflect the subset of the ...
4 years, 1 month ago (2016-11-18 23:48:31 UTC) #2
mpw
4 years, 1 month ago (2016-11-19 04:20:09 UTC) #4 
On 2016/11/18 23:48:31, Ryan Hamilton wrote:
> nit: please tweak the CL description (and the Final) to reflect the subset of
> the internal CL that is actually being merged.
> 
> lgtm

Oops! Done.

Powered by Google App Engine
This is Rietveld 408576698