Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2512163003: Re-mark overflow-height-float-not-removed-crash3.html as flaky. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
pdr., esprehn
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-mark overflow-height-float-not-removed-crash3.html as flaky. The flakiness tag was removed in 07fd19897e1811586bbdcce5 and later rebaselined in 6c4ad33831899ad35888e65ae47 but it seems it's still flaky. BUG=619427 Committed: https://crrev.com/57f4ab582649ebb6e9dc8721f0882b49f6c2ee19 Cr-Commit-Position: refs/heads/master@{#433369}

Patch Set 1 #

Patch Set 2 : not spv2 #

Patch Set 3 : both #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Evan Stade
4 years, 1 month ago (2016-11-18 20:37:30 UTC) #3
pdr.
On 2016/11/18 at 20:37:30, estade wrote: > crbug.com/666889, is looks like the flakiness dashboard is ...
4 years, 1 month ago (2016-11-18 20:51:42 UTC) #5
pdr.
On 2016/11/18 at 20:51:42, pdr. wrote: > On 2016/11/18 at 20:37:30, estade wrote: > > ...
4 years, 1 month ago (2016-11-18 20:53:07 UTC) #6
Evan Stade
ah, indeed. Do we need both or is the non-virtual one sufficient?
4 years, 1 month ago (2016-11-18 20:58:00 UTC) #7
pdr.
On 2016/11/18 at 20:58:00, estade wrote: > ah, indeed. Do we need both or is ...
4 years, 1 month ago (2016-11-18 21:53:29 UTC) #8
Evan Stade
done
4 years, 1 month ago (2016-11-19 00:03:47 UTC) #9
pdr.
On 2016/11/19 at 00:03:47, estade wrote: > done LGTM
4 years, 1 month ago (2016-11-19 00:04:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512163003/40001
4 years, 1 month ago (2016-11-19 00:05:25 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-19 01:20:57 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 01:28:34 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/57f4ab582649ebb6e9dc8721f0882b49f6c2ee19
Cr-Commit-Position: refs/heads/master@{#433369}

Powered by Google App Engine
This is Rietveld 408576698