Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: net/server/http_server_unittest.cc

Issue 251213004: HttpServer: avoid DCHECK'ing on non-HTTP/1.1 requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rm spurious nl Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/server/http_server_request_info.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/server/http_server_unittest.cc
diff --git a/net/server/http_server_unittest.cc b/net/server/http_server_unittest.cc
index 87c35b198e7b3d42d385681aedc576a3766e09d0..e18600459da91f07d52402baaa3d781af147a83b 100644
--- a/net/server/http_server_unittest.cc
+++ b/net/server/http_server_unittest.cc
@@ -208,11 +208,23 @@ TEST_F(HttpServerTest, Request) {
ASSERT_EQ("/test", GetRequest(0).path);
ASSERT_EQ("", GetRequest(0).data);
ASSERT_EQ(0u, GetRequest(0).headers.size());
+ ASSERT_EQ(HttpVersion(1, 1), GetRequest(0).http_version);
ASSERT_TRUE(StartsWithASCII(GetRequest(0).peer.ToString(),
"127.0.0.1",
true));
}
+TEST_F(HttpServerTest, InvalidHttpVersion) {
+ TestHttpClient client;
+ ASSERT_EQ(OK, client.ConnectAndWait(server_address_));
+ client.Send("GET /test HTTP//1\r\n\r\n");
+ ASSERT_TRUE(RunUntilRequestsReceived(1));
+ ASSERT_EQ("GET", GetRequest(0).method);
+ ASSERT_EQ("/test", GetRequest(0).path);
+ ASSERT_EQ("", GetRequest(0).data);
+ ASSERT_EQ(HttpVersion(1, 0), GetRequest(0).http_version);
+}
+
TEST_F(HttpServerTest, RequestWithHeaders) {
TestHttpClient client;
ASSERT_EQ(OK, client.ConnectAndWait(server_address_));
« no previous file with comments | « net/server/http_server_request_info.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698