Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: net/server/http_server.cc

Issue 251213004: HttpServer: avoid DCHECK'ing on non-HTTP/1.1 requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rm spurious nl Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/http_util.cc ('k') | net/server/http_server_request_info.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/server/http_server.h" 5 #include "net/server/http_server.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "base/strings/string_util.h" 11 #include "base/strings/string_util.h"
12 #include "base/strings/stringprintf.h" 12 #include "base/strings/stringprintf.h"
13 #include "base/sys_byteorder.h" 13 #include "base/sys_byteorder.h"
14 #include "build/build_config.h" 14 #include "build/build_config.h"
15 #include "net/base/net_errors.h" 15 #include "net/base/net_errors.h"
16 #include "net/http/http_util.h"
16 #include "net/server/http_connection.h" 17 #include "net/server/http_connection.h"
17 #include "net/server/http_server_request_info.h" 18 #include "net/server/http_server_request_info.h"
18 #include "net/server/http_server_response_info.h" 19 #include "net/server/http_server_response_info.h"
19 #include "net/server/web_socket.h" 20 #include "net/server/web_socket.h"
20 #include "net/socket/tcp_listen_socket.h" 21 #include "net/socket/tcp_listen_socket.h"
21 22
22 namespace net { 23 namespace net {
23 24
24 HttpServer::HttpServer(const StreamListenSocketFactory& factory, 25 HttpServer::HttpServer(const StreamListenSocketFactory& factory,
25 HttpServer::Delegate* delegate) 26 HttpServer::Delegate* delegate)
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 switch (state) { 276 switch (state) {
276 case ST_METHOD: 277 case ST_METHOD:
277 info->method = buffer; 278 info->method = buffer;
278 buffer.clear(); 279 buffer.clear();
279 break; 280 break;
280 case ST_URL: 281 case ST_URL:
281 info->path = buffer; 282 info->path = buffer;
282 buffer.clear(); 283 buffer.clear();
283 break; 284 break;
284 case ST_PROTO: 285 case ST_PROTO:
285 // TODO(mbelshe): Deal better with parsing protocol. 286 if (!HttpUtil::ParseVersion(buffer, &info->http_version)) {
286 DCHECK(buffer == "HTTP/1.1"); 287 // Treat everything else like HTTP 1.0
288 info->http_version = HttpVersion(1, 0);
289 }
287 buffer.clear(); 290 buffer.clear();
288 break; 291 break;
289 case ST_NAME: 292 case ST_NAME:
290 header_name = StringToLowerASCII(buffer); 293 header_name = StringToLowerASCII(buffer);
291 buffer.clear(); 294 buffer.clear();
292 break; 295 break;
293 case ST_VALUE: 296 case ST_VALUE:
294 base::TrimWhitespaceASCII(buffer, base::TRIM_LEADING, &header_value); 297 base::TrimWhitespaceASCII(buffer, base::TRIM_LEADING, &header_value);
295 // TODO(mbelshe): Deal better with duplicate headers 298 // TODO(mbelshe): Deal better with duplicate headers
296 DCHECK(info->headers.find(header_name) == info->headers.end()); 299 DCHECK(info->headers.find(header_name) == info->headers.end());
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 } 334 }
332 335
333 HttpConnection* HttpServer::FindConnection(StreamListenSocket* socket) { 336 HttpConnection* HttpServer::FindConnection(StreamListenSocket* socket) {
334 SocketToConnectionMap::iterator it = socket_to_connection_.find(socket); 337 SocketToConnectionMap::iterator it = socket_to_connection_.find(socket);
335 if (it == socket_to_connection_.end()) 338 if (it == socket_to_connection_.end())
336 return NULL; 339 return NULL;
337 return it->second; 340 return it->second;
338 } 341 }
339 342
340 } // namespace net 343 } // namespace net
OLDNEW
« no previous file with comments | « net/http/http_util.cc ('k') | net/server/http_server_request_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698