Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2512123003: [ObjC ARC] Converts ios/chrome/browser/invalidation:invalidation to ARC.Automatically generated A… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/invalidation:invalidation to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/b88732e627633f1843665e3d532275aa79db3756 Cr-Commit-Position: refs/heads/master@{#435322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/invalidation/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. passes downstream tests.
4 years ago (2016-11-25 09:50:28 UTC) #6
Eugene But (OOO till 7-30)
lgtm
4 years ago (2016-11-30 16:47:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512123003/1
4 years ago (2016-11-30 16:49:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 17:52:34 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-30 17:58:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b88732e627633f1843665e3d532275aa79db3756
Cr-Commit-Position: refs/heads/master@{#435322}

Powered by Google App Engine
This is Rietveld 408576698