Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2512093002: Add support for Pull Queues to prod implementation. (Closed)

Created:
4 years, 1 month ago by Vadim Sh.
Modified:
4 years, 1 month ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add support for Pull Queues to prod implementation. This CL adds the interface (corresponding to native one) and prod implementation. Memory implementation will be in a separate CL. R=iannucci@chromium.org BUG= Committed: https://github.com/luci/gae/commit/8ddad9162eff4fcb3c15f7cb0ac61fda3857565a

Patch Set 1 #

Total comments: 3

Patch Set 2 : use time.Duration for leaseTime #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -10 lines) Patch
M filter/count/tq.go View 1 3 chunks +21 lines, -0 lines 0 comments Download
M filter/featureBreaker/tq.go View 1 2 chunks +28 lines, -0 lines 0 comments Download
M impl/dummy/dummy.go View 1 1 chunk +8 lines, -5 lines 0 comments Download
M impl/memory/taskqueue.go View 1 3 chunks +25 lines, -0 lines 0 comments Download
M impl/prod/taskqueue.go View 1 3 chunks +30 lines, -0 lines 0 comments Download
M service/taskqueue/interface.go View 1 3 chunks +33 lines, -5 lines 0 comments Download
M service/taskqueue/raw_interface.go View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Vadim Sh.
PTAL, this is mostly boilerplate to make impl/memory CL smaller. https://codereview.chromium.org/2512093002/diff/1/service/taskqueue/interface.go File service/taskqueue/interface.go (right): https://codereview.chromium.org/2512093002/diff/1/service/taskqueue/interface.go#newcode77 ...
4 years, 1 month ago (2016-11-18 03:42:12 UTC) #1
Vadim Sh.
https://codereview.chromium.org/2512093002/diff/1/service/taskqueue/interface.go File service/taskqueue/interface.go (right): https://codereview.chromium.org/2512093002/diff/1/service/taskqueue/interface.go#newcode79 service/taskqueue/interface.go:79: // leaseTime is in seconds. The number of tasks ...
4 years, 1 month ago (2016-11-18 03:53:53 UTC) #2
Vadim Sh.
Switched to time.Duration instead of int for leaseTime.
4 years, 1 month ago (2016-11-18 04:04:56 UTC) #4
iannucci
lgtm
4 years, 1 month ago (2016-11-18 05:21:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512093002/20001
4 years, 1 month ago (2016-11-18 19:52:06 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 19:56:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/8ddad9162eff4fcb3c15f7cb0ac61fda3857565a

Powered by Google App Engine
This is Rietveld 408576698