Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc

Issue 2512073003: Aarch64 buildfix. (Closed)
Patch Set: Aarch64 buildfix. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc
diff --git a/sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc b/sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc
index ae35677de2b9046e8bb55cd23916952f6ae6d383..827ccd91e84bbf6a0591c98cb58c03f1e9b9b441 100644
--- a/sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc
+++ b/sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc
@@ -1877,15 +1877,23 @@ BPF_TEST_C(SandboxBPF, PthreadBitMask, PthreadPolicyBitMask) {
#if defined(__aarch64__)
#ifndef PTRACE_GETREGS
+#ifdef __GLIBC__
Jorge Lucangeli Obes 2016/11/22 16:56:49 Please use #if defined(...) here.
+#define PTRACE_GETREGS static_cast<enum __ptrace_request>(12)
+#else
#define PTRACE_GETREGS 12
#endif
Jorge Lucangeli Obes 2016/11/22 16:56:49 We have too many endifs. Let's comment what they d
#endif
+#endif
#if defined(__aarch64__)
#ifndef PTRACE_SETREGS
+#ifdef __GLIBC__
Jorge Lucangeli Obes 2016/11/22 16:56:49 Same.
+#define PTRACE_SETREGS static_cast<enum __ptrace_request>(13)
+#else
#define PTRACE_SETREGS 13
#endif
Jorge Lucangeli Obes 2016/11/22 16:56:49 Same: #endif // defined(__GLIBC__) #endif // !d
#endif
+#endif
// Changes the syscall to run for a child being sandboxed using seccomp-bpf with
// PTRACE_O_TRACESECCOMP. Should only be called when the child is stopped on
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698