Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: components/offline_pages/offline_page_model_query.cc

Issue 2512073002: [Offline Pages] Removes two-step expiration related. (Closed)
Patch Set: adding unit in histograms. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_query.cc
diff --git a/components/offline_pages/offline_page_model_query.cc b/components/offline_pages/offline_page_model_query.cc
index 57691cbe6d7e992d39c2bc9b6f3ffd791c427e00..5fe192dc5639632f200c2cf1658b728b3721019c 100644
--- a/components/offline_pages/offline_page_model_query.cc
+++ b/components/offline_pages/offline_page_model_query.cc
@@ -61,19 +61,12 @@ OfflinePageModelQueryBuilder::RequireRestrictedToOriginalTab(
return *this;
}
-OfflinePageModelQueryBuilder& OfflinePageModelQueryBuilder::AllowExpiredPages(
- bool allow_expired) {
- allow_expired_ = allow_expired;
- return *this;
-}
-
std::unique_ptr<OfflinePageModelQuery> OfflinePageModelQueryBuilder::Build(
ClientPolicyController* controller) {
DCHECK(controller);
auto query = base::MakeUnique<OfflinePageModelQuery>();
- query->allow_expired_ = allow_expired_;
query->urls_ = std::make_pair(
urls_.first, std::set<GURL>(urls_.second.begin(), urls_.second.end()));
urls_ = std::make_pair(Requirement::UNSET, std::vector<GURL>());
@@ -165,14 +158,7 @@ OfflinePageModelQuery::GetRestrictedToUrls() const {
return urls_;
}
-bool OfflinePageModelQuery::GetAllowExpired() const {
- return allow_expired_;
-}
-
bool OfflinePageModelQuery::Matches(const OfflinePageItem& item) const {
- if (!allow_expired_ && item.IsExpired())
- return false;
-
switch (offline_ids_.first) {
case Requirement::UNSET:
break;
« no previous file with comments | « components/offline_pages/offline_page_model_query.h ('k') | components/offline_pages/offline_page_model_query_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698