Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3936)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bookmark_observer.cc

Issue 2512073002: [Offline Pages] Removes two-step expiration related. (Closed)
Patch Set: adding unit in histograms. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bookmark_observer.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bookmark_observer.cc b/chrome/browser/android/offline_pages/offline_page_bookmark_observer.cc
index 335dadedc62e349c30adf2505ec61e169aef28b4..cfac924288c09539d84fd9ca63357871de012bf9 100644
--- a/chrome/browser/android/offline_pages/offline_page_bookmark_observer.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bookmark_observer.cc
@@ -35,19 +35,19 @@ void OfflinePageBookmarkObserver::BookmarkNodeRemoved(
ClientId client_id = ClientId(kBookmarkNamespace, std::to_string(node->id()));
offline_page_model_->GetOfflineIdsForClientId(
client_id,
- base::Bind(&OfflinePageBookmarkObserver::DoExpireRemovedBookmarkPages,
+ base::Bind(&OfflinePageBookmarkObserver::DoDeleteRemovedBookmarkPages,
weak_ptr_factory_.GetWeakPtr()));
}
-void OfflinePageBookmarkObserver::DoExpireRemovedBookmarkPages(
+void OfflinePageBookmarkObserver::DoDeleteRemovedBookmarkPages(
const MultipleOfflineIdResult& offline_ids) {
- offline_page_model_->ExpirePages(
- offline_ids, base::Time::Now(),
- base::Bind(&OfflinePageBookmarkObserver::OnExpireRemovedBookmarkPagesDone,
+ offline_page_model_->DeletePagesByOfflineId(
+ offline_ids,
+ base::Bind(&OfflinePageBookmarkObserver::OnDeleteRemovedBookmarkPagesDone,
weak_ptr_factory_.GetWeakPtr()));
}
-void OfflinePageBookmarkObserver::OnExpireRemovedBookmarkPagesDone(
- bool result) {}
+void OfflinePageBookmarkObserver::OnDeleteRemovedBookmarkPagesDone(
+ DeletePageResult result) {}
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698