[Offline Pages] Removes two-step expiration related.

components/offline_pages/offline_page_model_impl.h

Index: components/offline_pages/offline_page_model_impl.h
diff --git a/components/offline_pages/offline_page_model_impl.h b/components/offline_pages/offline_page_model_impl.h
index d5a4a7d954915dbfa544a3e5d86f08b9f2b0d5b1..3b6352b0820255121b52024e5764253594c82125 100644
--- a/components/offline_pages/offline_page_model_impl.h
+++ b/components/offline_pages/offline_page_model_impl.h
@@ -90,8 +90,6 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
       const std::set<GURL>& urls,
       const CheckPagesExistOfflineCallback& callback) override;
   void GetAllPages(const MultipleOfflinePageItemCallback& callback) override;
-  void GetAllPagesWithExpired(
-      const MultipleOfflinePageItemCallback& callback) override;
   void GetOfflineIdsForClientId(
       const ClientId& client_id,
       const MultipleOfflineIdCallback& callback) override;
@@ -101,9 +99,6 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
   void GetPagesByOnlineURL(
       const GURL& online_url,
       const MultipleOfflinePageItemCallback& callback) override;
-  void ExpirePages(const std::vector<int64_t>& offline_ids,
-                   const base::Time& expiration_time,
-                   const base::Callback<void(bool)>& callback) override;
   ClientPolicyController* GetPolicyController() override;
 
   // Methods for testing only:
@@ -189,14 +184,14 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
   // Callbacks for checking metadata consistency.
   void CheckMetadataConsistencyForArchivePaths(
       const std::set<base::FilePath>& archive_paths);
-  // Callback called after headless archives deleted. Orphaned archives are
+  // Callbacks called after orphaned archives deleted. Orphaned archives are
   // archives files on disk which are not pointed to by any of the page items
   // in metadata store.
-  void ExpirePagesMissingArchiveFile(
+  void DeletePagesMissingArchiveFile(
       const std::set<base::FilePath>& archive_paths);
-  void OnExpirePagesMissingArchiveFileDone(
+  void OnDeletePagesMissingArchiveFileDone(
       const std::vector<int64_t>& offline_ids,
-      bool success);
+      DeletePageResult result);
   void DeleteOrphanedArchives(const std::set<base::FilePath>& archive_paths);
   void OnDeleteOrphanedArchivesDone(const std::vector<base::FilePath>& archives,
                                     bool success);
@@ -226,16 +221,12 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
   void DoDeleteCachedPagesByURLPredicate(const UrlPredicate& predicate,
                                          const DeletePageCallback& callback);
 
-  // Callback completing page expiration.
-  void OnExpirePageDone(const base::Time& expiration_time,
-                        std::unique_ptr<OfflinePagesUpdateResult> result);
-
   // Clears expired pages if there are any.

[jianli, 2016/11/18 00:15:48]

Update comment.

[romax, 2016/11/18 20:50:49]

we still have pages which have been living longer than the time defined in
expiration_policy. These pages would be called expired pages.

   void ClearStorageIfNeeded(
       const OfflinePageStorageManager::ClearStorageCallback& callback);
 
   // Callback completing storage clearing.
-  void OnStorageCleared(size_t expired_page_count,
+  void OnStorageCleared(size_t cleared_page_count,
                         OfflinePageStorageManager::ClearStorageResult result);
 
   // Post task to clear storage.