Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: components/offline_pages/downloads/download_ui_adapter.cc

Issue 2512073002: [Offline Pages] Removes two-step expiration related. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/downloads/download_ui_adapter.cc
diff --git a/components/offline_pages/downloads/download_ui_adapter.cc b/components/offline_pages/downloads/download_ui_adapter.cc
index bb398cb8f025d372546d0d669b1137e76a555acd..df7be3489f6bca4d4498821a4729b23d6b1efd25 100644
--- a/components/offline_pages/downloads/download_ui_adapter.cc
+++ b/components/offline_pages/downloads/download_ui_adapter.cc
@@ -123,9 +123,6 @@ void DownloadUIAdapter::DeleteItem(const std::string& guid) {
std::vector<int64_t> page_ids;
page_ids.push_back(it->second->offline_id);
- // TODO(dimich): This should be ExpirePages(...Now()..) when Expire is
- // firing Observer method. The resulting Observer notification will update
- // local cache.
model_->DeletePagesByOfflineId(
page_ids, base::Bind(&DownloadUIAdapter::OnDeletePagesDone,
weak_ptr_factory_.GetWeakPtr()));

Powered by Google App Engine
This is Rietveld 408576698