Chromium Code Reviews Chromium Code Reviews
Issue 2512073002:
[Offline Pages] Removes two-step expiration related. (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index aa3575b9f814c4e7c1768773aa1597fadb0c178e..57369e6df6bc981fbd9f9ac1b6bf8ff7d51fd39c 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -39662,6 +39662,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <summary>Status code of wiping out the offline page data.</summary> |
| </histogram> |
| +<histogram name="OfflinePages.ClearStorageBatchSize"> |
|
Ilya Sherman
2016/11/29 02:44:20
nit: Please add a units attribute
romax
2016/11/29 19:38:16
Acknowledged.
I think I got the name wrong it shou
Ilya Sherman
2016/11/29 21:06:28
I think the name is okay either way. I'd still su
romax
2016/11/30 00:24:16
Done.
Sorry I think I just realized the point of a
|
| + <owner>romax@chromium.org</owner> |
| + <summary> |
| + Number of pages deleted in a batch during one clear-storage request. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="OfflinePages.ClearStorageResult" |
| enum="OfflinePagesClearStorageResult"> |
| <owner>romax@chromium.org</owner> |
| @@ -39676,8 +39683,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="OfflinePages.Consistency.DeletePagesMissingArchiveFileResult" |
| + enum="BooleanSuccess"> |
|
Ilya Sherman
2016/11/29 02:44:20
Hmm, is BooleanSuccess still the right enum?
romax
2016/11/29 19:38:16
Done.
|
| + <owner>romax@chromium.org</owner> |
| + <summary> |
| + Whether an attempt to delete pages without archives was successful. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="OfflinePages.Consistency.ExpirePagesMissingArchiveFileResult" |
| enum="BooleanSuccess"> |
| + <obsolete> |
| + Deprecated 11/2016, replaced by |
| + OfflinePages.Consistency.DeletePagesMissingArchiveFileResult. |
| + </obsolete> |
| <owner>romax@chromium.org</owner> |
| <summary> |
| Whether an attempt to expire pages without archives was successful. |
| @@ -39812,11 +39831,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </histogram> |
| <histogram name="OfflinePages.ExpirePage.BatchSize"> |
| + <obsolete> |
| + Deprecated 11/2016. Offline pages no longer use two-step expiration. |
| + </obsolete> |
| <owner>romax@chromium.org</owner> |
| <summary>Number of pages that are expired in a batch.</summary> |
| </histogram> |
| <histogram name="OfflinePages.ExpirePage.PageLifetime" units="minutes"> |
| + <obsolete> |
| + Deprecated 11/2016. Offline pages no longer use two-step expiration. |
| + </obsolete> |
| <owner>romax@chromium.org</owner> |
| <summary> |
| Length of time between when an offline page was created and was expired. |
| @@ -39825,11 +39850,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="OfflinePages.ExpirePage.StoreUpdateResult" |
| enum="BooleanSuccess"> |
| + <obsolete> |
| + Deprecated 11/2016. Offline pages no longer use two-step expiration. |
| + </obsolete> |
| <owner>romax@chromium.org</owner> |
| <summary>Result of updating expired page in store.</summary> |
| </histogram> |
| <histogram name="OfflinePages.ExpirePage.TimeSinceLastAccess" units="minutes"> |
| + <obsolete> |
| + Deprecated 11/2016. Offline pages no longer use two-step expiration. |
| + </obsolete> |
| <owner>romax@chromium.org</owner> |
| <summary> |
| Length of time between when an offline page was last opened and was expired. |
| @@ -94710,9 +94741,10 @@ value. |
| <enum name="OfflinePagesClearStorageResult" type="int"> |
| <int value="0" label="Success"/> |
| <int value="1" label="Unnecessary to clean"/> |
| - <int value="2" label="Page expiration failed"/> |
| + <int value="2" label="Page expiration failed (deprecated 11/2016)"/> |
| <int value="3" label="Page record deletion failed"/> |
| - <int value="4" label="Both expiration and deletion failed"/> |
| + <int value="4" |
| + label="Both expiration and deletion failed (deprecated 11/2016)"/> |
| </enum> |
| <enum name="OfflinePagesDeletePageResult" type="int"> |
