Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2512053002: tighten failure expectations already worked around in WebGL roll (Closed)

Created:
4 years, 1 month ago by Kai Ninomiya
Modified:
4 years ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

These tests seem to fail only on old versions of macOS (such as 10.10 Yosemite on the bots) BUG=665656 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/7001c082c7bde47d1326caa700e6b5693f3c2d4e Cr-Commit-Position: refs/heads/master@{#434577}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : expect failures for #665656 on yosemite only #

Patch Set 4 : fix #

Patch Set 5 : manual rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 35 (29 generated)
Kai Ninomiya
4 years, 1 month ago (2016-11-17 23:36:36 UTC) #3
Zhenyao Mo
On 2016/11/17 23:36:36, Kai Ninomiya wrote: lgtm
4 years, 1 month ago (2016-11-17 23:43:38 UTC) #4
Kai Ninomiya
On 2016/11/17 23:43:38, Zhenyao Mo wrote: > On 2016/11/17 23:36:36, Kai Ninomiya wrote: > > ...
4 years, 1 month ago (2016-11-18 01:41:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512053002/80001
4 years ago (2016-11-26 21:37:51 UTC) #30
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-11-26 21:42:20 UTC) #33
commit-bot: I haz the power
4 years ago (2016-11-26 21:44:57 UTC) #35
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7001c082c7bde47d1326caa700e6b5693f3c2d4e
Cr-Commit-Position: refs/heads/master@{#434577}

Powered by Google App Engine
This is Rietveld 408576698