Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: .gn

Issue 2512043002: Move the GN exec_script whitelist for //build into //build. (Closed)
Patch Set: tweak comment, remove skia file Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/dotfile_settings.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This file is used by the GN meta build system to find the root of the source 1 # This file is used by the GN meta build system to find the root of the source
2 # tree and to set startup options. For documentation on the values set in this 2 # tree and to set startup options. For documentation on the values set in this
3 # file, run "gn help dotfile" at the command line. 3 # file, run "gn help dotfile" at the command line.
4 4
5 import("//build/dotfile_settings.gni")
6
5 # The location of the build configuration file. 7 # The location of the build configuration file.
6 buildconfig = "//build/config/BUILDCONFIG.gn" 8 buildconfig = "//build/config/BUILDCONFIG.gn"
7 9
8 # The secondary source root is a parallel directory tree where 10 # The secondary source root is a parallel directory tree where
9 # GN build files are placed when they can not be placed directly 11 # GN build files are placed when they can not be placed directly
10 # in the source tree, e.g. for third party source trees. 12 # in the source tree, e.g. for third party source trees.
11 secondary_source = "//build/secondary/" 13 secondary_source = "//build/secondary/"
12 14
13 # These are the targets to check headers for by default. The files in targets 15 # These are the targets to check headers for by default. The files in targets
14 # matching these patterns (see "gn help label_pattern" for format) will have 16 # matching these patterns (see "gn help label_pattern" for format) will have
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 # - It's easy to screw up. One common case is a build-time script that packs 210 # - It's easy to screw up. One common case is a build-time script that packs
209 # up a directory. The author notices that the script isn't re-run when the 211 # up a directory. The author notices that the script isn't re-run when the
210 # directory is updated, so adds a glob so all the files are listed as 212 # directory is updated, so adds a glob so all the files are listed as
211 # inputs. This seems to work great... until a file is deleted. When a 213 # inputs. This seems to work great... until a file is deleted. When a
212 # file is deleted, all the inputs the glob lists will still be up to date 214 # file is deleted, all the inputs the glob lists will still be up to date
213 # and no command-lines will have been changed. The action will not be 215 # and no command-lines will have been changed. The action will not be
214 # re-run and the build will be broken. It is possible to get this correct 216 # re-run and the build will be broken. It is possible to get this correct
215 # using glob, and it's possible to mess it up without glob, but globs make 217 # using glob, and it's possible to mess it up without glob, but globs make
216 # this situation much easier to create. if the build always lists the 218 # this situation much easier to create. if the build always lists the
217 # files and passes them to a script, it will always be correct. 219 # files and passes them to a script, it will always be correct.
218 exec_script_whitelist = [
219 "//android_webview/BUILD.gn",
220 "//build_overrides/build.gni",
221 "//build/config/BUILD.gn",
222 "//build/config/android/config.gni",
223 "//build/config/android/internal_rules.gni",
224 "//build/config/android/rules.gni",
225 "//build/config/compiler/BUILD.gn",
226 "//build/config/gcc/gcc_version.gni",
227 "//build/config/ios/ios_sdk.gni",
228 "//build/config/linux/BUILD.gn",
229 "//build/config/linux/pkg_config.gni",
230 "//build/config/linux/atk/BUILD.gn",
231 "//build/config/mac/mac_sdk.gni",
232 "//build/config/mac/rules.gni",
233 "//build/config/posix/BUILD.gn",
234 "//build/config/sysroot.gni",
235 "//build/config/win/BUILD.gn",
236 "//build/config/win/visual_studio_version.gni",
237 "//build/toolchain/concurrent_links.gni",
238 "//build/toolchain/mac/BUILD.gn",
239 "//build/toolchain/nacl/BUILD.gn",
240 "//build/toolchain/toolchain.gni",
241 "//build/toolchain/win/BUILD.gn",
242 "//build/util/branding.gni",
243 "//build/util/version.gni",
244 "//chromeos/BUILD.gn",
245 220
246 # TODO(dgn): Layer violation but breaks the build otherwise, see 221 exec_script_whitelist =
247 # https://crbug.com/474506 222 build_dotfile_settings.exec_script_whitelist + [
248 "//clank/java/BUILD.gn", 223 # Whitelist entries for //build should go into
249 "//clank/native/BUILD.gn", 224 # //build/dotfile_settings.gni instead, so that they can be shared
225 # with other repos. The entries in this list should be only for files
226 # in the Chromium repo outside of //build.
227 "//android_webview/BUILD.gn",
228 "//build_overrides/build.gni",
229 "//chromeos/BUILD.gn",
250 230
251 "//jingle/BUILD.gn", 231 # TODO(dgn): Layer violation but breaks the build otherwise, see
252 "//net/BUILD.gn", 232 # https://crbug.com/474506.
253 "//remoting/host/installer/linux/BUILD.gn", 233 "//clank/java/BUILD.gn",
254 "//remoting/remoting_version.gni", 234 "//clank/native/BUILD.gn",
255 "//remoting/host/installer/win/generate_clsids.gni",
256 "//third_party/angle/BUILD.gn",
257 "//third_party/angle/src/tests/BUILD.gn",
258 "//third_party/angle/src/vulkan_support/BUILD.gn",
259 "//third_party/catapult/tracing/BUILD.gn",
260 "//third_party/google_input_tools/inputview.gni",
261 "//third_party/skia/gn/shared_sources.gni",
262 235
263 # CLD2 should be removed soon, delete this when we do. 236 "//jingle/BUILD.gn",
264 "//third_party/cld_2/BUILD.gn", 237 "//net/BUILD.gn",
265 "//tools/grit/grit_rule.gni", 238 "//remoting/host/installer/linux/BUILD.gn",
239 "//remoting/remoting_version.gni",
240 "//remoting/host/installer/win/generate_clsids.gni",
266 241
267 # Not gypi-to-gn. 242 # TODO(dpranke): Get these from the appropriate repos instead.
268 "//google_apis/BUILD.gn", 243 "//third_party/angle/BUILD.gn",
269 "//printing/BUILD.gn", 244 "//third_party/angle/src/tests/BUILD.gn",
270 ] 245 "//third_party/angle/src/vulkan_support/BUILD.gn",
246 "//third_party/catapult/tracing/BUILD.gn",
247 "//third_party/google_input_tools/inputview.gni",
248
249 # CLD2 should be removed soon, delete this when we do.
250 "//third_party/cld_2/BUILD.gn",
251 "//tools/grit/grit_rule.gni",
252
253 # Not gypi-to-gn.
254 "//google_apis/BUILD.gn",
255 "//printing/BUILD.gn",
256 ]
OLDNEW
« no previous file with comments | « no previous file | build/dotfile_settings.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698