Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 251203003: Update EUC-JP per WHATWG encoding spec (Closed)

Created:
6 years, 7 months ago by jungshik at Google
Modified:
6 years, 7 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Visibility:
Public.

Description

Update EUC-JP per WHATWG encoding spec - Add missing half-width kana entries (omitted by mistake) - Drop 'extra' decoding only mapping. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=25266 - Regenerate icu data files (*dat and assembly source files) for Linux, Mac, Windows and Android. (they'll not be shown at codereview.chromium.org because they're too large). BUG=132145, 78847 TEST=When ICU is rolled in, base_unittests --gtest_filter=*ICU* and layout tests R=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -55 lines) Patch
M icu52/android/icudtl.dat View Binary file 0 comments Download
M icu52/scripts/eucjp_gen.sh View 4 chunks +5 lines, -31 lines 0 comments Download
M icu52/source/data/in/icudtl.dat View Binary file 0 comments Download
M icu52/source/data/mappings/euc-jp-html5.ucm View 5 chunks +63 lines, -24 lines 0 comments Download
M icu52/windows/icudt.dll View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
Can you take a look? Thanks. BTW, I was in the middle of reviewing your ...
6 years, 7 months ago (2014-04-29 07:49:13 UTC) #1
jsbell
lgtm
6 years, 7 months ago (2014-04-29 17:37:25 UTC) #2
jungshik at Google
6 years, 7 months ago (2014-04-29 18:04:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r266919 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698