third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js - Issue 2512013002: [DevTools] Handle external link clicks and context menu separately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2512013002: [DevTools] Handle external link clicks and context menu separately. (Closed)

Patch Set: formatting Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js ('k') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

index a91f944ded9ce016ab3f500078f068af2d1ee02d..df9398a6d7ff1821a2f319fa57879c7930bb2550 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

@@ -1211,7 +1211,7 @@ Elements.ElementsTreeElement = class extends TreeElement {

value = value.replace(closingPunctuationRegex, '$&\u200B');

if (value.startsWith('data:'))

value = value.trimMiddle(60);

- var anchor = node.nodeName().toLowerCase() === 'a' ? UI.createExternalLink(rewrittenHref, value) :

+ var anchor = node.nodeName().toLowerCase() === 'a' ? UI.createExternalLink(rewrittenHref, value, '', true) :

lushnikov 2016/11/18 00:39:17 why do you want to preventClick here?

Components.Linkifier.linkifyURLAsNode(rewrittenHref, value);

anchor.preventFollow = true;

return anchor;