Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: ppapi/native_client/tests/breakpad_crash_test/nacl.scons

Issue 25120002: linux_aura: Turn aura on on the builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update documentation in nacl.scons about the real bug I filed. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | tools/lsan/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/tests/breakpad_crash_test/nacl.scons
diff --git a/ppapi/native_client/tests/breakpad_crash_test/nacl.scons b/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
index f3ce99a0a58df783999a593bedaee1b04a481a4b..64900721487079b72fd85160ea9ccd67a8eab5ca 100644
--- a/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
+++ b/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
@@ -83,8 +83,13 @@ env.AddNodeToTestSuite(
node, ['chrome_browser_tests'], 'run_breakpad_crash_in_syscall_test',
# This test is currently flaky on Win 32 bit on x86, disabling there.
# See bug: https://code.google.com/p/chromium/issues/detail?id=254583
+ #
+ # These tests are also disabled on linux_aura, pending debugging of why the
+ # GPU process crashes. piman@ thinks it may be a simple flags issue.
+ # See bug: https://code.google.com/p/chromium/issues/detail?id=303342
is_broken=env.PPAPIBrowserTesterIsBroken() or
env.Bit('running_on_valgrind') or
+ env.Bit('host_linux') or
(env.Bit('host_windows') and env.Bit('build_x86_32')))
# Crashes in untrusted code should not produce crash dumps.
@@ -98,5 +103,10 @@ node = env.PPAPIBrowserTester(
args=platform_args + ['--expected_crash_dumps=0'])
env.AddNodeToTestSuite(
node, ['chrome_browser_tests'], 'run_breakpad_untrusted_crash_test',
+ # This currently reliably fails in linux_aura configurations, probably for
+ # the same reasons that the previous test fails.
+ #
+ # See bug: https://code.google.com/p/chromium/issues/detail?id=303342
is_broken=env.PPAPIBrowserTesterIsBroken() or
- env.Bit('running_on_valgrind'))
+ env.Bit('running_on_valgrind') or
+ env.Bit('host_linux'))
« no previous file with comments | « build/common.gypi ('k') | tools/lsan/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698