Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2511973005: Revert of [NTP] Refresh download list when NTP is open. (Closed)

Created:
4 years, 1 month ago by Benoit L
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [NTP] Refresh download list when NTP is open. (patchset #2 id:20001 of https://codereview.chromium.org/2508133004/ ) Reason for revert: Broke tests. See crbug.com/666744 Original issue's description: > [NTP] Refresh download list when NTP is open. > > So that we do not show on new NTPs items which were removed bypassing Chrome. > > BUG=666262 > > Committed: https://crrev.com/a17ba56880d3431adc2626ee006f7f65e703c84d > Cr-Commit-Position: refs/heads/master@{#433174} TBR=bauerb@chromium.org,markusheintz@chromium.org,vitaliii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=666262 Committed: https://crrev.com/e259c656eefd44425e3075ccec88853b7ec5fef8 Cr-Commit-Position: refs/heads/master@{#433195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Benoit L
Created Revert of [NTP] Refresh download list when NTP is open.
4 years, 1 month ago (2016-11-18 14:49:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511973005/1
4 years, 1 month ago (2016-11-18 14:49:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 14:50:43 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e259c656eefd44425e3075ccec88853b7ec5fef8 Cr-Commit-Position: refs/heads/master@{#433195}
4 years, 1 month ago (2016-11-18 14:52:49 UTC) #7
vitaliii
4 years, 1 month ago (2016-11-18 15:18:49 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2510423002/ by vitaliii@chromium.org.

The reason for reverting is: I am going to solve the initial issue..

Powered by Google App Engine
This is Rietveld 408576698