Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2511963002: remove support for analyzer configuration in pubspec (Closed)

Created:
4 years, 1 month ago by danrubel
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove support for analyzer configuration in pubspec This removes support for having directives like this in your pubspec: analyzer: configuration: test_pack/config R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/74d713ece957d5b8985d11e747bd6bbfca3b2823

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -369 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 3 chunks +0 lines, -24 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 1 chunk +0 lines, -211 lines 0 comments Download
D pkg/analyzer/lib/source/config.dart View 1 chunk +0 lines, -108 lines 0 comments Download
D pkg/analyzer/test/source/config_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M pkg/analyzer/test/source/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
4 years, 1 month ago (2016-11-17 21:37:24 UTC) #2
Brian Wilkerson
lgtm, thanks!
4 years, 1 month ago (2016-11-17 22:12:15 UTC) #3
danrubel
4 years, 1 month ago (2016-11-21 01:44:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
74d713ece957d5b8985d11e747bd6bbfca3b2823 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698