Consider payment method specific data when filtering payment apps.

Consider payment method specific data when filtering payment apps.

Chrome filters payment apps by payment method, e.g., "visa",
"mastercard", or "https://android.com/pay". With the upcoming
implementation of the new "basic-card" payment method, the filtering
needs to be based on the method specific data. The following snippet,
for example, specifies the "visa" and "debit" filters inside of the
method specific data.

new PaymentRequest([{
                     supportedMethods: ['basic-card'],
                     data: {
                       supportedNetworks: ['visa'],
                       supportedTypes: ['debit']
                     }
                   }],
                   shoppingCartContents);

This patch adds ability to filter out payment apps based on method
specific data as well as the list of payment methods that they support.

BUG=665190
Committed: https://crrev.com/e71bf006592c9ebba8c459848308b27e3efa63b4
Cr-Commit-Position: refs/heads/master@{#433731}

[please use gerrit instead, 2016-11-18 22:27:19]

Description was changed from

==========
Add PaymentApp.supportsMethodAndData()

BUG=665190
==========

to

==========
Consider payment method specific data when filtering payment apps.

Chrome filters payment apps by payment method, e.g., "visa",
"mastercard", or "https://android.com/pay". With the upcoming
implementation of the new "basic-card" payment method, the filtering
needs to be based on the method specific data. The following snippet,
for example, specifies the "visa" and "debit" filters inside of the
method specific data.

new PaymentRequest([{
                     supportedMethods: ['basic-card'],
                     data: {
                       supportedNetworks: ['visa'],
                       supportedTypes: ['debit']
                     }
                   }],
                   shoppingCartContents);

This patch adds ability to filter out payment apps based on method
specific data as well as the list of payment methods that they support.

BUG=665190
==========

[please use gerrit instead, 2016-11-18 22:27:28]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 22:28:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-11-18 22:28:43]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-11-18 22:30:21]

rouslan@chromium.org changed reviewers:
+ tedchoc@chromium.org

[please use gerrit instead, 2016-11-18 22:30:22]

Ted, ptal.

This is a part of http://crrev.com/2501593003 that Dan has asked me to split up.
I don't want to overload Dan with all of the shards of that CL, so was I hoping
that maybe you could review this shard instead of him. Thank you!

[commit-bot: I haz the power, 2016-11-18 23:04:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 23:04:33]

Dry run: This issue passed the CQ dry run.

[Ted C, 2016-11-21 22:18:13]

lgtm

https://codereview.chromium.org/2511953004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2511953004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:461:
filterMerchantMethodData(mMethodData, app.getAppMethodNames());
Should this map be converted to unmodifiable?

https://developer.android.com/reference/java/util/Collections.html#unmodifiab...
extends K, ? extends V>)

I guess we generate a new map for each PaymentApp so they aren't clobbering each
other I don't think, but wondering if passing the map to the payment is
potential error vector.

[please use gerrit instead, 2016-11-21 23:18:34]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-11-21 23:18:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2511953004/#ps40001
(title: "Unmodifiable")

[please use gerrit instead, 2016-11-21 23:18:43]

https://codereview.chromium.org/2511953004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
(right):

https://codereview.chromium.org/2511953004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:461:
filterMerchantMethodData(mMethodData, app.getAppMethodNames());
On 2016/11/21 22:18:13, Ted C wrote:
> Should this map be converted to unmodifiable?
> 
>
https://developer.android.com/reference/java/util/Collections.html#unmodifiab...
> extends K, ? extends V>)
> 
> I guess we generate a new map for each PaymentApp so they aren't clobbering
each
> other I don't think, but wondering if passing the map to the payment is
> potential error vector.

Made appMethods unmodifiable. This is something I should be using more. It's
pretty nifty (i.e., useful).

[commit-bot: I haz the power, 2016-11-21 23:19:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-11-22 00:42:45]

The CQ bit was unchecked by rouslan@chromium.org

[please use gerrit instead, 2016-11-22 00:50:11]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-11-22 00:50:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2511953004/#ps60001
(title: "Don't pass null into Collections.unmodifiable()")

[commit-bot: I haz the power, 2016-11-22 00:50:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 01:29:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479775811828240,
"parent_rev": "65f6d0a1a437a7c48cb9b31f1880600d025ef5be", "commit_rev":
"49b2217f1f0cebf3aed78890744f91156bc6be5f"}

[commit-bot: I haz the power, 2016-11-22 01:29:51]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-22 01:31:51]

Description was changed from

==========
Consider payment method specific data when filtering payment apps.

Chrome filters payment apps by payment method, e.g., "visa",
"mastercard", or "https://android.com/pay". With the upcoming
implementation of the new "basic-card" payment method, the filtering
needs to be based on the method specific data. The following snippet,
for example, specifies the "visa" and "debit" filters inside of the
method specific data.

new PaymentRequest([{
                     supportedMethods: ['basic-card'],
                     data: {
                       supportedNetworks: ['visa'],
                       supportedTypes: ['debit']
                     }
                   }],
                   shoppingCartContents);

This patch adds ability to filter out payment apps based on method
specific data as well as the list of payment methods that they support.

BUG=665190
==========

to

==========
Consider payment method specific data when filtering payment apps.

Chrome filters payment apps by payment method, e.g., "visa",
"mastercard", or "https://android.com/pay". With the upcoming
implementation of the new "basic-card" payment method, the filtering
needs to be based on the method specific data. The following snippet,
for example, specifies the "visa" and "debit" filters inside of the
method specific data.

new PaymentRequest([{
                     supportedMethods: ['basic-card'],
                     data: {
                       supportedNetworks: ['visa'],
                       supportedTypes: ['debit']
                     }
                   }],
                   shoppingCartContents);

This patch adds ability to filter out payment apps based on method
specific data as well as the list of payment methods that they support.

BUG=665190

Committed: https://crrev.com/e71bf006592c9ebba8c459848308b27e3efa63b4
Cr-Commit-Position: refs/heads/master@{#433731}
==========

[commit-bot: I haz the power, 2016-11-22 01:31:52]

Patchset 3 (id:??) landed as
https://crrev.com/e71bf006592c9ebba8c459848308b27e3efa63b4
Cr-Commit-Position: refs/heads/master@{#433731}

[please use gerrit instead, 2016-11-22 01:47:57]

Description was changed from

==========
Consider payment method specific data when filtering payment apps.

Chrome filters payment apps by payment method, e.g., "visa",
"mastercard", or "https://android.com/pay". With the upcoming
implementation of the new "basic-card" payment method, the filtering
needs to be based on the method specific data. The following snippet,
for example, specifies the "visa" and "debit" filters inside of the
method specific data.

new PaymentRequest([{
                     supportedMethods: ['basic-card'],
                     data: {
                       supportedNetworks: ['visa'],
                       supportedTypes: ['debit']
                     }
                   }],
                   shoppingCartContents);

This patch adds ability to filter out payment apps based on method
specific data as well as the list of payment methods that they support.

BUG=665190

Committed: https://crrev.com/e71bf006592c9ebba8c459848308b27e3efa63b4
Cr-Commit-Position: refs/heads/master@{#433731}
==========

to

==========
Consider payment method specific data when filtering payment apps.

Chrome filters payment apps by payment method, e.g., "visa",
"mastercard", or "https://android.com/pay". With the upcoming
implementation of the new "basic-card" payment method, the filtering
needs to be based on the method specific data. The following snippet,
for example, specifies the "visa" and "debit" filters inside of the
method specific data.

new PaymentRequest([{
                     supportedMethods: ['basic-card'],
                     data: {
                       supportedNetworks: ['visa'],
                       supportedTypes: ['debit']
                     }
                   }],
                   shoppingCartContents);

This patch adds ability to filter out payment apps based on method
specific data as well as the list of payment methods that they support.

BUG=665190

Committed: https://crrev.com/e71bf006592c9ebba8c459848308b27e3efa63b4
Cr-Commit-Position: refs/heads/master@{#433731}
==========