Enabled volume buttons when TouchView is active

ash/test/volume_control_delegate_stub.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_TEST_VOLUME_CONTROL_DELEGATE_STUB_H_
+#define ASH_TEST_VOLUME_CONTROL_DELEGATE_STUB_H_
+
+#include "ash/volume_control_delegate.h"
+#include "ui/base/accelerators/accelerator.h"
+
+namespace ash {
+
+// A simple TestDouble for a VolumeControlDelegate

[flackr, 2014/04/30 14:27:44]

TestDouble?

[bruthig, 2014/04/30 15:36:16]

"A test double is an object that can stand in for a real object in a test"

See
https://big.corp.google.com/~jmcmaster/testing/2013/08/episode-296-know-your-...

[flackr, 2014/04/30 15:43:10]

Ah okay, I hadn't heard the term before and the TitleCase made me think it was a
chromium class / type. Can you call it a test touble rather than a TestDouble?

+// Will count the number of times the HandleVolumeMute, HandleVolumeDown and
+// HandleVolumeUp methods are invoked and will return a predefined value from
+// these methods.  The predefined value is defined upon construction.

[flackr, 2014/04/30 14:27:44]

No need to mention the predefined consume value. here.

[bruthig, 2014/04/30 15:36:16]

Done.

+class VolumeControlDelegateStub : public ash::VolumeControlDelegate {

[flackr, 2014/04/30 14:27:44]

For consistency, it looks like the other mock implementations of delegates used
for tests are called TestXDelegate, so how about TestVolumeControlDelegate?

[bruthig, 2014/04/30 15:36:16]

For consistency I've renamed it to TestVolumeControlDelegate but I may add this
to my radar for some 20% work

[bruthig, 2014/04/30 15:36:16]

Done.

+ public:
+  explicit VolumeControlDelegateStub(bool consume);
+  virtual ~VolumeControlDelegateStub();
+
+  int handle_volume_mute_count() const {
+    return handle_volume_mute_count_;
+  }
+
+  int handle_volume_down_count() const {
+    return handle_volume_down_count_;
+  }
+
+  int handle_volume_up_count() const {
+    return handle_volume_up_count_;
+  }
+
+  const ui::Accelerator& last_accelerator() const {
+    return last_accelerator_;
+  }
+
+  // ash::VolumeControlDelegate:
+  virtual bool HandleVolumeMute(const ui::Accelerator& accelerator) OVERRIDE;
+  virtual bool HandleVolumeDown(const ui::Accelerator& accelerator) OVERRIDE;
+  virtual bool HandleVolumeUp(const ui::Accelerator& accelerator) OVERRIDE;
+
+ private:
+  bool consume_;

[flackr, 2014/04/30 14:27:44]

Can comment what consume means here instead.

[bruthig, 2014/04/30 15:36:16]

Done.

+  int handle_volume_mute_count_;
+  int handle_volume_down_count_;
+  int handle_volume_up_count_;
+  ui::Accelerator last_accelerator_;
+
+  DISALLOW_COPY_AND_ASSIGN(VolumeControlDelegateStub);
+};
+
+}  // namespace ash
+
+#endif  // ASH_TEST_VOLUME_CONTROL_DELEGATE_STUB_H_