Enabled volume buttons when TouchView is active

ash/test/dummy_volume_control_delegate.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_TEST_DUMMY_VOLUME_CONTROL_DELEGATE_H_
+#define ASH_TEST_DUMMY_VOLUME_CONTROL_DELEGATE_H_
+
+#include "ash/volume_control_delegate.h"
+#include "ui/base/accelerators/accelerator.h"
+
+namespace ash {
+
+class DummyVolumeControlDelegate : public ash::VolumeControlDelegate {
+ public:
+  explicit DummyVolumeControlDelegate(bool consume);
+  virtual ~DummyVolumeControlDelegate();
+
+  virtual bool HandleVolumeMute(const ui::Accelerator& accelerator) OVERRIDE;

[jonross, 2014/04/29 14:42:43]

Above a block of overridden methods leave a comment for which class they extend:

// ash::VolumeControlDelegate:

[bruthig, 2014/04/29 15:49:00]

Done.

+  virtual bool HandleVolumeDown(const ui::Accelerator& accelerator) OVERRIDE;
+  virtual bool HandleVolumeUp(const ui::Accelerator& accelerator) OVERRIDE;
+
+  int handle_volume_mute_count() const;

[jonross, 2014/04/29 14:42:43]

Overridden methods should come last. So these should be placed above

[bruthig, 2014/04/29 15:49:00]

Done.

+  int handle_volume_down_count() const;
+  int handle_volume_up_count() const;
+  const ui::Accelerator& last_accelerator() const;
+
+ private:
+  const bool consume_;

[jonross, 2014/04/29 14:42:43]

We don't really use const on class member variables. This one is actually set in
the constructor, so it could become a normal member variable.

For constants we defined them within the cc file in an anonymous namespace.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Constant_Names

[bruthig, 2014/04/29 15:49:00]

Done.

+  int handle_volume_mute_count_;
+  int handle_volume_down_count_;
+  int handle_volume_up_count_;
+  ui::Accelerator last_accelerator_;
+
+  DISALLOW_COPY_AND_ASSIGN(DummyVolumeControlDelegate);
+};
+
+}  // namespace ash
+
+#endif  // ASH_TEST_DUMMY_VOLUME_CONTROL_DELEGATE_H_