Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2511923002: <select>: ignore modified keydown events in some cases (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, esprehn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<select>: ignore modified keydown events in some cases For example, don't mark Alt + left/right handled so that back/forward continue to work when a <select> is focused. R=tkent@chromium.org BUG=666179 Committed: https://crrev.com/82e245731a18bee4a64ba37e3cd4aeace09c8274 Cr-Commit-Position: refs/heads/master@{#433589}

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/select/ignore-keydown-with-modifiers.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Dan Beam
4 years, 1 month ago (2016-11-19 02:41:55 UTC) #7
tkent
lgtm. Please remove 'MD Settings' from the CL summary. This change is not specific to ...
4 years, 1 month ago (2016-11-21 00:31:11 UTC) #12
Dan Beam
On 2016/11/21 00:31:11, tkent wrote: > lgtm. > > Please remove 'MD Settings' from the ...
4 years, 1 month ago (2016-11-21 16:51:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511923002/60001
4 years, 1 month ago (2016-11-21 16:51:56 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 1 month ago (2016-11-21 18:21:27 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 18:24:23 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82e245731a18bee4a64ba37e3cd4aeace09c8274
Cr-Commit-Position: refs/heads/master@{#433589}

Powered by Google App Engine
This is Rietveld 408576698