Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2511893002: Paint solid color background into both scrolling contents layer and graphics layer. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@gmail.com> 10 * Christian Biesinger <cbiesinger@gmail.com>
(...skipping 1672 matching lines...) Expand 10 before | Expand all | Expand 10 after
1683 if (node && node->isElementNode() && 1683 if (node && node->isElementNode() &&
1684 (toElement(node)->compositorMutableProperties() & 1684 (toElement(node)->compositorMutableProperties() &
1685 (CompositorMutableProperty::kScrollTop | 1685 (CompositorMutableProperty::kScrollTop |
1686 CompositorMutableProperty::kScrollLeft))) 1686 CompositorMutableProperty::kScrollLeft)))
1687 return true; 1687 return true;
1688 1688
1689 // TODO(flackr): Allow integer transforms as long as all of the ancestor 1689 // TODO(flackr): Allow integer transforms as long as all of the ancestor
1690 // transforms are also integer. 1690 // transforms are also integer.
1691 bool backgroundSupportsLCDText = 1691 bool backgroundSupportsLCDText =
1692 RuntimeEnabledFeatures::compositeOpaqueScrollersEnabled() && 1692 RuntimeEnabledFeatures::compositeOpaqueScrollersEnabled() &&
1693 layer->canPaintBackgroundOntoScrollingContentsLayer() && 1693 layer->backgroundPaintLocation() & BackgroundPaintInScrollingContents &&
1694 layer->backgroundIsKnownToBeOpaqueInRect( 1694 layer->backgroundIsKnownToBeOpaqueInRect(
1695 toLayoutBox(layer->layoutObject())->paddingBoxRect()) && 1695 toLayoutBox(layer->layoutObject())->paddingBoxRect()) &&
1696 !layer->compositesWithTransform() && !layer->compositesWithOpacity(); 1696 !layer->compositesWithTransform() && !layer->compositesWithOpacity();
1697 if (mode == PaintLayerScrollableArea::ConsiderLCDText && 1697 if (mode == PaintLayerScrollableArea::ConsiderLCDText &&
1698 !layer->compositor()->preferCompositingToLCDTextEnabled() && 1698 !layer->compositor()->preferCompositingToLCDTextEnabled() &&
1699 !backgroundSupportsLCDText) 1699 !backgroundSupportsLCDText)
1700 return false; 1700 return false;
1701 1701
1702 // TODO(schenney) Tests fail if we do not also exclude 1702 // TODO(schenney) Tests fail if we do not also exclude
1703 // layer->layoutObject()->style()->hasBorderDecoration() (missing background 1703 // layer->layoutObject()->style()->hasBorderDecoration() (missing background
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
1967 1967
1968 void PaintLayerScrollableArea::DelayScrollOffsetClampScope:: 1968 void PaintLayerScrollableArea::DelayScrollOffsetClampScope::
1969 clampScrollableAreas() { 1969 clampScrollableAreas() {
1970 for (auto& scrollableArea : *s_needsClamp) 1970 for (auto& scrollableArea : *s_needsClamp)
1971 scrollableArea->clampScrollOffsetsAfterLayout(); 1971 scrollableArea->clampScrollOffsetsAfterLayout();
1972 delete s_needsClamp; 1972 delete s_needsClamp;
1973 s_needsClamp = nullptr; 1973 s_needsClamp = nullptr;
1974 } 1974 }
1975 1975
1976 } // namespace blink 1976 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698