Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2511883006: Mojo C++ bindings: switch services/ui/public/interfaces mojom target to use STL types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch services/ui/public/interfaces mojom target to use STL types. BUG=662515 Committed: https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d Cr-Commit-Position: refs/heads/master@{#433581}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -377 lines) Patch
M mojo/public/cpp/bindings/map.h View 1 chunk +26 lines, -0 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.h View 1 2 chunks +19 lines, -14 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.cc View 1 4 chunks +10 lines, -8 lines 0 comments Download
M services/ui/public/cpp/tests/window_tree_client_private.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/public/cpp/tests/window_tree_client_unittest.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download
M services/ui/public/cpp/window.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.h View 9 chunks +23 lines, -18 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.cc View 15 chunks +43 lines, -46 lines 0 comments Download
M services/ui/public/interfaces/BUILD.gn View 4 chunks +3 lines, -27 lines 0 comments Download
M services/ui/ws/display.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/display.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ws/test_change_tracker.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/test_change_tracker.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M services/ui/ws/test_utils.h View 1 2 5 chunks +15 lines, -11 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M services/ui/ws/window_tree.h View 6 chunks +23 lines, -19 lines 0 comments Download
M services/ui/ws/window_tree.cc View 15 chunks +37 lines, -39 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 1 2 10 chunks +23 lines, -21 lines 0 comments Download
M services/ui/ws/window_tree_unittest.cc View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M ui/aura/mus/drag_drop_controller_mus.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 6 chunks +17 lines, -14 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 14 chunks +37 lines, -55 lines 0 comments Download
M ui/aura/mus/window_tree_client_unittest.cc View 1 2 11 chunks +34 lines, -30 lines 0 comments Download
M ui/aura/test/mus/test_window_tree.h View 1 2 4 chunks +25 lines, -18 lines 0 comments Download
M ui/aura/test/mus/test_window_tree.cc View 1 2 5 chunks +15 lines, -13 lines 0 comments Download
M ui/aura/test/mus/window_tree_client_private.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-21 01:34:41 UTC) #8
sky
LGTM
4 years, 1 month ago (2016-11-21 16:48:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511883006/40001
4 years, 1 month ago (2016-11-21 17:38:46 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 17:44:08 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 17:47:48 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a5ee17d8ae92239f11977ceaf622e34cfe0772d
Cr-Commit-Position: refs/heads/master@{#433581}

Powered by Google App Engine
This is Rietveld 408576698