Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: Source/web/WebKit.cpp

Issue 251183006: Web Animations: Timeline should not advance during task execution (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use task start time Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebKit.cpp
diff --git a/Source/web/WebKit.cpp b/Source/web/WebKit.cpp
index aa722a53f5ba662b3636d54f163e60608a5afc34..fb5c54457ec4163422a07915cd8668da6a32788f 100644
--- a/Source/web/WebKit.cpp
+++ b/Source/web/WebKit.cpp
@@ -35,6 +35,7 @@
#include "bindings/v8/V8Binding.h"
#include "bindings/v8/V8Initializer.h"
#include "core/Init.h"
+#include "core/animation/AnimationClock.h"
#include "core/dom/Microtask.h"
#include "core/frame/Settings.h"
#include "core/page/Page.h"
@@ -66,7 +67,10 @@ namespace {
class EndOfTaskRunner : public WebThread::TaskObserver {
dstockwell 2014/04/30 12:07:22 We probably want to rename this, or create a separ
public:
- virtual void willProcessTask() { }
+ virtual void willProcessTask()
+ {
+ WebCore::AnimationClock::notifyTaskStartTime(monotonicallyIncreasingTime());
esprehn 2014/04/30 22:43:50 How expensive is monotonicallyIncreasingTime? Can
dstockwell 2014/04/30 22:59:51 I will investigate.
+ }
abarth-chromium 2014/04/30 22:39:16 Doesn't this make the entire engine slower? We ex
dstockwell 2014/05/01 00:22:21 I'm going to try a new approach which should reduc
virtual void didProcessTask()
{
WebCore::Microtask::performCheckpoint();
« Source/core/animation/AnimationClockTest.cpp ('K') | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698