Source/web/WebKit.cpp - Issue 251183006: Web Animations: Timeline should not advance during task execution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebKit.cpp

Issue 251183006: Web Animations: Timeline should not advance during task execution (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Tick animation clock using approximate frame time. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebKit.cpp

diff --git a/Source/web/WebKit.cpp b/Source/web/WebKit.cpp

index e2615483f845f2685a54a7c72ba93b39bec94f5d..649fa5a465da05c1eac08b353e0d5186d9f95f0b 100644

--- a/Source/web/WebKit.cpp

+++ b/Source/web/WebKit.cpp

@@ -35,6 +35,7 @@

#include "bindings/v8/V8Binding.h"

#include "bindings/v8/V8Initializer.h"

#include "core/Init.h"

+#include "core/animation/AnimationClock.h"

#include "core/dom/Microtask.h"

#include "core/frame/Settings.h"

#include "core/page/Page.h"

@@ -66,7 +67,10 @@ namespace {

class EndOfTaskRunner : public WebThread::TaskObserver {

public:

- virtual void willProcessTask() { }

+ virtual void willProcessTask()

esprehn 2014/05/07 06:07:06 Can you add OVERRIDE to both of these?

dstockwell 2014/05/07 06:51:38 Done.

+ {

+ WebCore::AnimationClock::notifyTaskStart();

+ }

virtual void didProcessTask()

{

WebCore::Microtask::performCheckpoint();

« Source/core/dom/Document.cpp ('K') | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »